Merged Derek Bruening requested to merge i4953-histogram-cast into master 3 years ago

Fixes a raw2trace cast from 32-bit app_pc to 64-bit int that was incorrectly sign-extending, to fix the histogram test's invariant check failure.

Issue: #4953 (closed)

Activity

Abhinav Anil Sharma @abhinav92003 started a thread on commit bd12f3b6 3 years ago

Last updated by Derek Bruening 3 years ago

clients/drcachesim/tracer/raw2trace.h

1030	1030	TESTANY(OFFLINE_FILE_TYPE_FILTERED, impl()->get_file_type(tls));
Abhinav Anil Sharma @abhinav92003 · 3 years ago Contributor Also remove the ignore-list entry: https://github.com/DynamoRIO/dynamorio/blob/02b88bb247899af74f95a42b1f512c0a64070686/suite/runsuite_wrapper.pl#L348 Derek Bruening @derekbruening · 3 years ago Author Contributor Done.

Derek Bruening requested review from @abhinav92003 3 years ago

requested review from @abhinav92003
Abhinav Anil Sharma approved this merge request 3 years ago

approved this merge request
Administrator @root · 3 years ago

Contributor

Merged by: derekbruening at 2021-09-20 22:53:28 UTC
Derek Bruening closed 3 years ago

closed

Please register or sign in to reply

Menu

Explore