Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !5541
An error occurred while fetching the assigned milestone of the selected merge_request.

i#4014 dr$sim phys: Fix 2 crashes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4014-crash into master 2 years ago
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 4

Fixes two bugs causing crashes with -use_physical:

  • Records the drcontext used for hashtable creation to ensure the same one is used at destruction as a different thread can call the exit event.

  • Orders the drmemtrace thread exit event before the drmodtrack one to ensure drmodtrack access during the final thread buffer output is safe.

These fixes were manually tested on large multi-threaded applications where these two crashes showed up before and disappear with the fixes.

Issue: #4014

Activity

  • Loading
  • Loading
  • Loading
Please register or sign in to reply
  1. 21 Jun, 2022 1 commit
    • Derek Bruening's avatar
      i#4014 dr$sim phys: Fix 2 crashes · 9c9daa95
      Derek Bruening authored 2 years ago
      Fixes two bugs causing crashes with -use_physical:
      
      + Records the drcontext used for hashtable creation to ensure the same
        one is used at destruction as a different thread can call the exit
        event.
      
      + Orders the drmemtrace thread exit event before the drmodtrack one to
        ensure drmodtrack access during the final thread buffer output is safe.
      
      These fixes were manually tested on large multi-threaded applications
      where these two crashes showed up before and disappear with the fixes.
      
      Issue: #4014
      9c9daa95
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
3
3 participants
Derek Bruening
Nahome Bete
Administrator
Reference:
Source branch: i4014-crash

Menu

Explore Projects Groups Snippets