Skip to content
GitLab

[dart-dio-next] Improve handling nullable objects

Merged Administrator requested to merge github/fork/Bdaya-Dev/dart-dio-next/use-nullable-json-objects into master

Created by: ahmednfwela

Currently nullable types need to be handled better at serialization level, for example: deserializing BuiltMap<String,JsonObject> when one of the values is null will throw an error at run time, since JsonObject is not a nullable type

these changes are not perfect, especially changing these

typeMapping.put("object", "JsonObject?");
typeMapping.put("AnyType", "JsonObject?");

imports.put("JsonObject?", "package:built_value/json_object.dart");

but I am not sure what's the best approach for putting the null operator (?) after a type ?

also this PR makes use of the FullType.nullable named constructor for defining serializers

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh bin/configs/dart*
./bin/utils/export_docs_generators.sh
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC: @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob