Created by: ppngn
Hi, I have tried to use struct models with newest Pistache version but it does not compile:
- bunch of conversion warnings (truncating from 32-bit int to 16-bit uint)
- Pistache::Optional was used but it got removed from Pistache some time ago
- validation was missing, I have ported the validation to struct model, I think it looks okay - I have generated samples with
useStructModel: "true"
and the part related to validation did not change in PetStore sample
I have run bin/generate-samples.sh
and it modified a bunch of files in .NET Core generator, but I didn't commit these files, apart from that everything else is committed.
$ git status
On branch pistache-fix-struct-model
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: samples/client/petstore/csharp-netcore/OpenAPIClient-generichost-net6.0-nrt/.openapi-generator/FILES
modified: samples/client/petstore/csharp-netcore/OpenAPIClient-generichost-net6.0/.openapi-generator/FILES
modified: samples/client/petstore/csharp-netcore/OpenAPIClient-generichost-netstandard2.0/.openapi-generator/FILES
@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.