Created by: noordawod
This pr brings back 2 lost "features" that were present earlier (and of course with the proper explanation as to why we need them back), and introduces a couple of new features as well:
- Inside a function, private-style variables (
var _json
) make no sense – so removed the underscore. TheauthNames
were mysteriously dropped, why? These are important information to each endpoint, and the authentication implementation may need to check which authentications to apply for each operation.- Removed use of the bang operator (
!
) when activating the authentication implementation – just use what Dart gives us out of the box:authentication?.applyToParams(…)
- Converted the
applyToParams
method to aFuture<void>
. Custom implementations may need to retrieve data from persistent stores, for example, and so may need this. SinceAuthentication
is an interface, and in caseApiClient
is inherited, one can now declare the genericT extends Authentication
class upon extension. Helps to access properties added in the inherited class (yes, this is backward-compatible and Dart, luckily, doesn't scream about it.)
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328 @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela