Created by: ggershoni
Please see https://github.com/OpenAPITools/openapi-generator/issues/1392 for details
Note: I needed to update autotest-fsevent (0.2.13)
to autotest-fsevent (0.2.14)
in Gemfile.lock
to make rspec work on macOS.
Would love your thoughts/advice @cliffano @zlx.
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,3.4.x
,4.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
In AbstractRubyCodegen
overloaded public String toRegularExpression(String pattern)
from DefaultCodegen
. Am not escaping the pattern (so no extra \ added) since the regex pattern is run inside regex delimiters already.
Added tests in both Java and Ruby client code.