Skip to content
GitLab

[PHP] Fix username and password check

Merged Administrator requested to merge github/fork/jfastnacht/1408-php-username-empty-check into master

Created by: jfastnacht

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Trying to fix the issue #1408 (closed) . Intermediate result, WIP.

Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.

@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon