Created by: tomghyselinck
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
,./bin/security/{LANG}-petstore.sh
and./bin/openapi3/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,. Default:3.4.x
,4.0.x
master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. -- @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess
Description of the PR
The generated Python server model code incorrectly escapes the regular expressions. Fixes #1823 (closed)
The code in the Python client was generated correctly.
Overriding DefaultCodegen::toRegularExpression
seems to do the trick.
The client also overrides DefaultCodegen::addRegularExpressionDelimiter
but it does not seem to be required. It is even incorrect IMHO (please correct me if I'm wrong).
I did tests on a local build with our company's product OpenAPI spec file. All regular expressions seem to be correct now.