Skip to content
GitLab

[C++][Pistache] Fix warnings

Merged Administrator requested to merge github/fork/muttleyxd/fix-pistache-warnings into master

Created by: muttleyxd

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @ravinikam @stkrwork @etherealjoy @MartinDelille

Description of the PR

GCC would complain about two warnings

(...)/api/(...)Api.cpp:24:92: warning: extra ‘;’ [-Wpedantic]
 (...)Api::(...)Api(std::shared_ptr<Pistache::Rest::Router> rtr) { router = rtr; };
(..)/api/(...)Api.cpp: In member function ‘void org::openapitools::server::api::(...)Api::(...)_api_default_handler(const Pistache::Rest::Request&, Pistache::Http::ResponseWriter)’:
(...)/api/(...)Api.cpp:124:69: warning: unused parameter ‘request’ [-Wunused-parameter]
 void (...)Api::(...)_api_default_handler(const Pistache::Rest::Request& request,