Skip to content
GitLab

[Elm] Template improvements

Merged Administrator requested to merge github/fork/laughedelic/elm-improvs into master

Created by: laughedelic

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes #458 (closed) and improves doc comments and line spacing in the Elm template. (see also https://github.com/swagger-api/swagger-codegen/issues/8152 for the context).

There are still some extra newlines that are hard to get rid of. They appear because the {{>blah}} includes bring the last newline in the parent template. I don't know if this can be somehow improved on the Mustache side, but in general it's quite hard to produce some code that immediately complies with the formatting guideline (elm-format).