Created by: mdavis-xyz
Fixes #6899
Previously, the python-flask
template had getter and setter functions, which validate that required arguments are passed, and enum values are in the list of accepted options etc.
But these functions were never actually called, because of a one line typo. They were circumvented.
Ideally I'd like to write a unit test to check that if you try to instantiate a model without a required argument, or with an unaccepted enum, that the instantiation fails. But I'm not familiar with how to add tests to this project.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.: @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11) @wing328