Created by: ityuhui
@wing328 @zhemant @michelealbano
Described in libcurl official document https://curl.haxx.se/libcurl/c/libcurl.html, the functions curl_global_init
and curl_global_cleanup
cannot be called in multiple thread environment, or it will cause a coredump.
Following by the guide, this PR removes the 2 function calls from apiClient_create*
and apiClient_free
, and adds 2 new functions for user to call:
/*
* In single thread program, the function apiClient_setupGlobalEnv is not needed.
* But in multi-thread program, apiClient_setupGlobalEnv must be called before any worker thread is created
*/
void apiClient_setupGlobalEnv()
{
curl_global_init(CURL_GLOBAL_ALL);
}
/*
* This function apiClient_unsetupGlobalEnv must be called whether single or multiple program.
* In multi-thread program, it is must be called after all worker threads end.
*/
void apiClient_unsetupGlobalEnv()
{
curl_global_cleanup();
}
Then user can create more than one api clients with multiple threads safely.
The difference compared with the original use case in single thread environment is:
User needs call the function apiClient_unsetupGlobalEnv
at the end of program.
The detail discussion can be found at the issue: https://github.com/kubernetes-client/c/issues/34
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.