Created by: aliakseiz
Fixes invalid code generation, when multipart/form-data requestBody contains array of files (OpenAPITools#8093).
In addition to existing ReadFormFileToTempFile
function a new one introduced ReadFormFilesToTempFiles
returning a slice of *os.File
.
To avoid code duplication, common part related to FileHeader
reading and storing in temporary file moved to new readFileHeaderToTempFile
function.
controller-api.mustache
updated to invoke corresponding function, depending on either single or multiple files are in a request.
Condition verifying the os
package import extended in GoServerCodegen.java
with a slice of files type.
Replaced a temporary directory path "tmp"
with ""
in ioutil.TempFile
call to make TempFile()
using the default os.TempDir
directory.
Testing
Existing automated tests passed. No new tests added.
Built project locally, manually tested generated code with different specifications (single file, array of files, various file formats).
Technical committee
@antihax @grokify @kemokemo @bkabrda
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.