Created by: thiagoarrais
Since #8137 the generated Go client no longer returns error results. It instead prefers the openapi-generator specific GenericOpenAPIError concrete type. This breaks expectations from Go developers: the main one being that returned errors are nullable and that a null error result means successful conclusion.
This PR reverts that change but tries to keep up with the spirit of the original PR by still allowing the response body to be accessed by client code. It also changes the generated documentation to make the possibility of getting detailed errors clearer.
Fixes #8263 (closed) (please refer to issue for aditional discussion).
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master,5.1.x,6.0.x -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)