Merged
requested to merge github/fork/toby-murray-snow-software/9151/bump-okhttp-to-latest into master
Created by: toby-murray-snow-software
In 5.0.1 the generated line in ApiClient
was:
return RequestBody.create(MediaType.parse(contentType), (byte[]) obj);
in 5.1.0 it is:
return RequestBody.create((byte[]) obj, MediaType.parse(contentType));
Looks like this change was introduced in #8969, and requires a more recent version of OkHttp to compile in some (all?) circumstances.
I tested out the failing spec that was mentioned in the linked ticket, and it compiles now.
To fix #9151 (closed)
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)