Created by: JulianGmp
The current generated codes for the C++ pistache server does not pass the correct default value for strings (and thus enums) to the templates. This PR just fixes that.
That way, non-required enum values are not set to an empty string in the constructor of a model, if a corresponding default value is specified.
yaml example
Pet:
type: object
required:
- someEnum
- someOtherEnum
- someString
- someOtherString
properties:
someEnum:
type: string
enum: [EnumVal1, EnumVal2, EnumVal3]
default: EnumVal1
someOtherEnum:
type: string
enum: [OtherEnumVal1, OtherEnumVal2, OtherEnumVal3]
someString:
type: string
default: "hello world"
someOtherString:
type: string
generated constructor:
Pet::Pet()
{
m_SomeEnum = "EnumVal1";
m_SomeOtherEnum = "";
m_SomeString = "hello world";
m_SomeOtherString = "";
}
Please note that the someOtherEnum
value still receives an invalid value, since no valid default was defined!
NOTE: I did run the generate-samples script, but it did not generate differing files. I suspect that the samples don't have this edge case anywhere.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd