Skip to content
GitLab

Fixed some Windows tests

Closed Administrator requested to merge github/fork/v-jizhang/testfixes into master

Created by: v-jizhang

Summary:

There are some test failures on Windows platform. It's time to fix them.

Test Plan:

  • The following tests can be run as commands in a CMD window buck test //test/com/facebook/buck/core/module/impl/moduleclass:moduleclass-test buck test //test/com/facebook/buck/core/module/impl/modulewithdeps:modulewithdeps-test buck test //test/com/facebook/buck/core/module/impl/modulewithexternaldeps:modulewithexternaldeps-test

  • The following tests can be run in IntelliJ: ListeningProcessExecutorTest.clearsEnvWhenExplicitlySet ExternalJavacIntegrationTest.whenBuckdUsesExternalJavacThenClientEnvironmentUsed JarGenruleTest.jarGenruleIsExecutable JavacStepTest.failedCompileSendsStdoutAndStderrToConsole JavacStepTest.existingBootclasspathDirSucceeds ListeningProcessExecutorTest.clearsEnvWhenExplicitlySet