Test class properties (#5183)

* Test flow types are stripped before class properties are transformed * Do not search multiple levels deep * Revert "Do not search multiple levels deep" This reverts commit 5b5324da. * Add missing file for test script to boot * Make sure src and node modules are ignored * Fix error * derp * fix test * Drop unneeded check

Test class properties (#5183)
* Test flow types are stripped before class properties are transformed * Do not search multiple levels deep * Revert "Do not search multiple levels deep" This reverts commit 5b5324da. * Add missing file for test script to boot * Make sure src and node modules are ignored * Fix error * derp * fix test * Drop unneeded check
02b8c355 · Joe Haddad · GitHub · 3c703401 · 02b8c355 · 02b8c355
Unverified Commit 02b8c355 authored 6 years ago by Joe Haddad Committed by GitHub 6 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 54 additions and 1 deletion
+54 -1
--- a/fixtures/smoke/issue-5176-flow-class-properties/index.test.js
+++ b/fixtures/smoke/issue-5176-flow-class-properties/index.test.js
+const { bootstrap, isSuccessfulTest } = require('../../utils');
+beforeEach(async () => {
+  await bootstrap({ directory: global.testDirectory, template: __dirname });
+});
+
+describe('issue #5176 (flow class properties interaction)', () => {
+  it('passes tests', async () => {
+    await isSuccessfulTest({
+      directory: global.testDirectory,
+      jestEnvironment: 'node',
+    });
+  });
+});
--- a/fixtures/smoke/issue-5176-flow-class-properties/package.json
+++ b/fixtures/smoke/issue-5176-flow-class-properties/package.json
+{}
--- a/fixtures/smoke/issue-5176-flow-class-properties/public/index.html
+++ b/fixtures/smoke/issue-5176-flow-class-properties/public/index.html
+<!DOCTYPE html>
+  <html lang="en">
+  <head>
+    <title>React App</title>
+  </head>
+  <body>
+    <div id="root"></div>
+  </body>
+</html>
--- a/fixtures/smoke/issue-5176-flow-class-properties/src/App.js
+++ b/fixtures/smoke/issue-5176-flow-class-properties/src/App.js
+class App {
+  constructor() {
+    this.foo = this.foo.bind(this);
+  }
+  foo: void => void;
+  foo() {
+    return 'bar';
+  }
+}
+
+export default App;
--- a/fixtures/smoke/issue-5176-flow-class-properties/src/App.test.js
+++ b/fixtures/smoke/issue-5176-flow-class-properties/src/App.test.js
+import App from './App';
+
+it('creates instance without', () => {
+  const app = new App();
+  expect(app.foo()).toBe('bar');
+});
--- a/fixtures/smoke/jest.config.js
+++ b/fixtures/smoke/jest.config.js
 module.exports = {
  testEnvironment: 'node',
  testMatch: ['**/*.test.js'],
+  testPathIgnorePatterns: ['/src/', 'node_modules'],
  setupTestFrameworkScriptFile: './setupSmokeTests.js',
 };
--- a/fixtures/utils.js
+++ b/fixtures/utils.js
@@ -14,7 +14,7 @@ async function bootstrap({ directory, template }) {
  );
  if (shouldInstallScripts) {
    const packageJson = fs.readJsonSync(path.join(directory, 'package.json'));
-    packageJson.dependencies = Object.assign(packageJson.dependencies, {
+    packageJson.dependencies = Object.assign({}, packageJson.dependencies, {
      'react-scripts': 'latest',
    });
    fs.writeJsonSync(path.join(directory, 'package.json'), packageJson);
@@ -67,6 +67,17 @@ async function isSuccessfulProduction({ directory }) {
  }
 }

+async function isSuccessfulTest({ directory, jestEnvironment = 'jsdom' }) {
+  await execa(
+    './node_modules/.bin/react-scripts',
+    ['test', '--env', jestEnvironment, '--ci'],
+    {
+      cwd: directory,
+      env: { CI: 'true' },
+    }
+  );
+}
+
 async function getOutputDevelopment({ directory, env = {} }) {
  try {
    const { stdout, stderr } = await execa(
@@ -128,6 +139,7 @@ module.exports = {
  bootstrap,
  isSuccessfulDevelopment,
  isSuccessfulProduction,
+  isSuccessfulTest,
  getOutputDevelopment,
  getOutputProduction,
 };