Exit with an error code when npm/yarn install fails (#1224)

Previously create-react-app exited with 0 after an installation error.

Exit with an error code when npm/yarn install fails (#1224)
Previously create-react-app exited with 0 after an installation error.
0990ce08 · Ville Immonen · GitHub · 2e02e36b · 0990ce08
Commit 0990ce08 authored 8 years ago by Ville Immonen Committed by GitHub 8 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 2 additions and 2 deletions
+2 -2
--- a/packages/create-react-app/index.js
+++ b/packages/create-react-app/index.js
@@ -142,10 +142,10 @@ function run(root, appName, version, verbose, originalDirectory) {
  var packageToInstall = getInstallPackage(version);
  var packageName = getPackageName(packageToInstall);

-  install(packageToInstall, verbose, function (code, command, args) {
+  install(packageToInstall, verbose, function(code, command, args) {
    if (code !== 0) {
      console.error('`' + command + ' ' + args.join(' ') + '` failed');
-      return;
+      process.exit(1);
    }

    checkNodeVersion(packageName);