Add lint rule to disallow require.ensure and System.import (#1536)

09cfcde0 · Tharaka Wijebandara · Dan Abramov · 0ef9e803 · 09cfcde0
Commit 09cfcde0 authored 8 years ago by Tharaka Wijebandara Committed by Dan Abramov 8 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 9 additions and 0 deletions
+9 -0
--- a/packages/eslint-config-react-app/index.js
+++ b/packages/eslint-config-react-app/index.js
@@ -155,6 +155,15 @@ module.exports = {
    'unicode-bom': ['warn', 'never'],
    'use-isnan': 'warn',
    'valid-typeof': 'warn',
+    'no-restricted-properties': ['error', {
+      object: 'require',
+      property: 'ensure',
+      message: 'Please use import() instead. More info: https://webpack.js.org/guides/code-splitting-import/#dynamic-import'
+    }, {
+      object: 'System',
+      property: 'import',
+      message: 'Please use import() instead. More info: https://webpack.js.org/guides/code-splitting-import/#dynamic-import'
+    }],

    // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/