Commit 0d0536f9 authored by Dan Abramov's avatar Dan Abramov
Browse files

Fix vertical alignment of close button

parent 8dc9217b
3 merge requests!12191Lim.Pisey.168:/Identified - We are currently investigating reports of missing build logs. The issue has been identified and a resolution is in progress. We will provide a further update when available.Mar 21, 09:02 UTC,!12853brikk,!5717Automatically extract project file structure from build bundle file
Showing with 15 additions and 14 deletions
+15 -14
/* @flow */ /* @flow */
import { applyStyles } from '../utils/dom/css'; import { applyStyles } from '../utils/dom/css';
import { groupStyle, groupElemLeft, groupElemRight } from '../styles'; import {
additionalChildStyle,
groupStyle,
groupElemLeft,
groupElemRight,
} from '../styles';
import { consumeEvent } from '../utils/dom/consumeEvent'; import { consumeEvent } from '../utils/dom/consumeEvent';
import { enableTabClick } from '../utils/dom/enableTabClick'; import { enableTabClick } from '../utils/dom/enableTabClick';
...@@ -20,7 +25,9 @@ function updateAdditional( ...@@ -20,7 +25,9 @@ function updateAdditional(
return; return;
} }
const span = document.createElement('span'); const div = document.createElement('div');
applyStyles(div, additionalChildStyle);
const group = document.createElement('span'); const group = document.createElement('span');
applyStyles(group, groupStyle); applyStyles(group, groupStyle);
...@@ -44,12 +51,12 @@ function updateAdditional( ...@@ -44,12 +51,12 @@ function updateAdditional(
group.appendChild(left); group.appendChild(left);
group.appendChild(right); group.appendChild(right);
span.appendChild(group); div.appendChild(group);
const text = `${currentError} of ${totalErrors} errors on the page`; const text = `${currentError} of ${totalErrors} errors on the page`;
span.appendChild(document.createTextNode(text)); div.appendChild(document.createTextNode(text));
additionalReference.appendChild(span); additionalReference.appendChild(div);
} }
export type { SwitchCallback }; export type { SwitchCallback };
......
/* @flow */ /* @flow */
import { applyStyles } from '../utils/dom/css'; import { applyStyles } from '../utils/dom/css';
import { import { containerStyle, overlayStyle, headerStyle } from '../styles';
containerStyle,
overlayStyle,
headerStyle,
additionalStyle,
} from '../styles';
import { createClose } from './close'; import { createClose } from './close';
import { createFrames } from './frames'; import { createFrames } from './frames';
import { createFooter } from './footer'; import { createFooter } from './footer';
...@@ -42,7 +37,6 @@ function createOverlay( ...@@ -42,7 +37,6 @@ function createOverlay(
// Create "Errors X of Y" in case of multiple errors // Create "Errors X of Y" in case of multiple errors
const additional = document.createElement('div'); const additional = document.createElement('div');
applyStyles(additional, additionalStyle);
updateAdditional( updateAdditional(
document, document,
additional, additional,
......
...@@ -64,7 +64,7 @@ const closeButtonStyle = { ...@@ -64,7 +64,7 @@ const closeButtonStyle = {
top: 0, top: 0,
}; };
const additionalStyle = { const additionalChildStyle = {
'margin-bottom': '0.5rem', 'margin-bottom': '0.5rem',
}; };
...@@ -197,7 +197,7 @@ export { ...@@ -197,7 +197,7 @@ export {
hintsStyle, hintsStyle,
hintStyle, hintStyle,
closeButtonStyle, closeButtonStyle,
additionalStyle, additionalChildStyle,
headerStyle, headerStyle,
functionNameStyle, functionNameStyle,
linkStyle, linkStyle,
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment