From 10eae80ead436c23ad42db0c0dc9b500f519c14e Mon Sep 17 00:00:00 2001
From: Conor Hastings <hastings.conorm@gmail.com>
Date: Sat, 23 Jul 2016 11:17:58 -0400
Subject: [PATCH] add node engine to package.json and call checkNodeVersion
function in cli (#88)
---
global-cli/index.js | 3 +++
package.json | 3 +++
2 files changed, 6 insertions(+)
diff --git a/global-cli/index.js b/global-cli/index.js
index ea5f3c1dd..22bfddc1f 100644
--- a/global-cli/index.js
+++ b/global-cli/index.js
@@ -112,6 +112,8 @@ function run(root, appName, version, verbose) {
return;
}
+ checkNodeVersion();
+
var scriptsPath = path.resolve(
process.cwd(),
'node_modules',
@@ -157,5 +159,6 @@ function checkNodeVersion() {
process.version,
packageJson.engines.node
);
+ process.exit(1);
}
}
diff --git a/package.json b/package.json
index aed0d9fb5..0bf487482 100644
--- a/package.json
+++ b/package.json
@@ -4,6 +4,9 @@
"description": "Configuration and scripts for Create React App.",
"repository": "facebookincubator/create-react-app",
"license": "BSD-3-Clause",
+ "engines": {
+ "node": ">=4"
+ },
"bugs": {
"url": "https://github.com/facebookincubator/create-react-app/issues"
},
--
GitLab