From 1359cc492cbc83d74f2382e3c22b0965c215e9a3 Mon Sep 17 00:00:00 2001
From: Patrick Dillon <pdillon@users.noreply.github.com>
Date: Tue, 11 Oct 2016 07:38:45 -0400
Subject: [PATCH] Support passing scoped package names to --scripts-version arg
(#826)
* Support passing scoped package names to --scripts-version arg
* Factor out bitwise operator in indexOf test
* Comment on stripping only version or tag from package name arg
---
packages/create-react-app/index.js | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/packages/create-react-app/index.js b/packages/create-react-app/index.js
index 02f9de254..1ea4f108c 100644
--- a/packages/create-react-app/index.js
+++ b/packages/create-react-app/index.js
@@ -152,10 +152,11 @@ function getInstallPackage(version) {
// Extract package name from tarball url or path.
function getPackageName(installPackage) {
- if (~installPackage.indexOf('.tgz')) {
+ if (installPackage.indexOf('.tgz') > -1) {
return installPackage.match(/^.+\/(.+)-.+\.tgz$/)[1];
- } else if (~installPackage.indexOf('@')) {
- return installPackage.split('@')[0];
+ } else if (installPackage.indexOf('@') > 0) {
+ // Do not match @scope/ when stripping off @version or @tag
+ return installPackage.charAt(0) + installPackage.substr(1).split('@')[0];
}
return installPackage;
}
--
GitLab