Forked react-scripts should retain the binary name (#754)

* Forked react-scripts should retain the binary name * Forked react-scripts should retain the binary name -- fixed issue with regex * Forked react-scripts should retain the binary name -- fixed style nit

Forked react-scripts should retain the binary name (#754)
* Forked react-scripts should retain the binary name * Forked react-scripts should retain the binary name -- fixed issue with regex * Forked react-scripts should retain the binary name -- fixed style nit
1b6f58cf · Shubheksha Jalan · Dan Abramov · e0dfa305 · 1b6f58cf · 1b6f58cf
Commit 1b6f58cf authored 8 years ago by Shubheksha Jalan Committed by Dan Abramov 8 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 5 additions and 8 deletions
+5 -8
--- a/packages/react-scripts/scripts/eject.js
+++ b/packages/react-scripts/scripts/eject.js
@@ -94,10 +94,7 @@ prompt(
  delete appPackage.scripts['eject'];
  Object.keys(appPackage.scripts).forEach(function (key) {
    appPackage.scripts[key] = appPackage.scripts[key]
-      .replace(
-        new RegExp(ownPackageName + ' (\\w+)', 'g'),
-        'node scripts/$1.js'
-      );
+      .replace(/react-scripts (\w+)/g, 'node scripts/$1.js');
  });

  // Add Jest config

--- a/packages/react-scripts/scripts/init.js
+++ b/packages/react-scripts/scripts/init.js
@@ -24,10 +24,10 @@ module.exports = function(appPath, appName, verbose, originalDirectory) {

  // Setup the script rules
  appPackage.scripts = {
-    'start': ownPackageName + ' start',
-    'build': ownPackageName + ' build',
-    'test': ownPackageName + ' test --env=jsdom',
-    'eject': ownPackageName + ' eject'
+    'start': 'react-scripts start',
+    'build': 'react-scripts build',
+    'test': 'react-scripts test --env=jsdom',
+    'eject': 'react-scripts eject'
  };

  fs.writeFileSync(