From 4534fd0954a56acb70dcf9ecd36317e5bbd9567b Mon Sep 17 00:00:00 2001 From: Dan Abramov <dan.abramov@gmail.com> Date: Sat, 3 Sep 2016 20:35:20 +0100 Subject: [PATCH] Update Flow instructions (#567) --- template/README.md | 35 ++--------------------------------- 1 file changed, 2 insertions(+), 33 deletions(-) diff --git a/template/README.md b/template/README.md index 5a7dfa796..b798dfed3 100644 --- a/template/README.md +++ b/template/README.md @@ -376,48 +376,17 @@ node_modules/fbjs/lib/Deferred.js.flow:60 node_modules/fbjs/lib/shallowEqual.js.flow:29 29: return x !== 0 || 1 / (x: $FlowIssue) === 1 / (y: $FlowIssue); ^^^^^^^^^^ identifier `$FlowIssue`. Could not resolve name - -src/App.js:3 - 3: import logo from './logo.svg'; - ^^^^^^^^^^^^ ./logo.svg. Required module not found - -src/App.js:4 - 4: import './App.css'; - ^^^^^^^^^^^ ./App.css. Required module not found - -src/index.js:5 - 5: import './index.css'; - ^^^^^^^^^^^^^ ./index.css. Required module not found ``` To fix this, change your `.flowconfig` to look like this: ```ini -[libs] -./node_modules/fbjs/flow/lib - -[options] -esproposal.class_static_fields=enable -esproposal.class_instance_fields=enable - -module.name_mapper='^\(.*\)\.css$' -> 'react-scripts/config/flow/css' -module.name_mapper='^\(.*\)\.\(jpg\|png\|gif\|eot\|otf\|webp\|svg\|ttf\|woff\|woff2\|mp4\|webm\)$' -> 'react-scripts/config/flow/file' - -suppress_type=$FlowIssue -suppress_type=$FlowFixMe +[ignore] +<PROJECT_ROOT>/node_modules/fbjs/.* ``` Re-run flow, and you shouldn’t get any extra issues. -If you later `eject`, you’ll need to replace `react-scripts` references with the `<PROJECT_ROOT>` placeholder, for example: - -```ini -module.name_mapper='^\(.*\)\.css$' -> '<PROJECT_ROOT>/config/flow/css' -module.name_mapper='^\(.*\)\.\(jpg\|png\|gif\|eot\|otf\|webp\|svg\|ttf\|woff\|woff2\|mp4\|webm\)$' -> '<PROJECT_ROOT>/config/flow/file' -``` - -We will consider integrating more tightly with Flow in the future so that you don’t have to do this. - ## Adding Custom Environment Variables >Note: this feature is available with `react-scripts@0.2.3` and higher. -- GitLab