Still emit runtime chunk (#5184)

789933c0 · Joe Haddad · GitHub · 02b8c355 · 789933c0
Unverified Commit 789933c0 authored 6 years ago by Joe Haddad Committed by GitHub 6 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 10 additions and 7 deletions
+10 -7
--- a/packages/react-dev-utils/InlineChunkHtmlPlugin.js
+++ b/packages/react-dev-utils/InlineChunkHtmlPlugin.js
@@ -43,13 +43,16 @@ class InlineChunkHtmlPlugin {
        assets.headTags = assets.headTags.map(tagFunction);
        assets.bodyTags = assets.bodyTags.map(tagFunction);
      });
-      hooks.afterEmit.tap('InlineChunkHtmlPlugin', () => {
-        Object.keys(compilation.assets).forEach(assetName => {
+      // Still emit the runtime chunk for users who do not use our generated
-          if (this.tests.some(test => assetName.match(test))) {
+      // index.html file.
-            delete compilation.assets[assetName];
+      // hooks.afterEmit.tap('InlineChunkHtmlPlugin', () => {
-          }
+      //   Object.keys(compilation.assets).forEach(assetName => {
-        });
+      //     if (this.tests.some(test => assetName.match(test))) {
-      });
+      //       delete compilation.assets[assetName];
+      //     }
+      //   });
+      // });
    });
  }
 }