From 7b881f12e398fc6bcfdf39a0a3fafde8b48bac7e Mon Sep 17 00:00:00 2001
From: Ade Viankakrisna Fadlil <viankakrisna@gmail.com>
Date: Thu, 11 Jan 2018 00:43:32 +0700
Subject: [PATCH] move the link for deployment to the bottom (#3736)
---
.../printHostingInstructions.js | 74 +++++++++----------
1 file changed, 36 insertions(+), 38 deletions(-)
diff --git a/packages/react-dev-utils/printHostingInstructions.js b/packages/react-dev-utils/printHostingInstructions.js
index aa440377c..4f761dfb0 100644
--- a/packages/react-dev-utils/printHostingInstructions.js
+++ b/packages/react-dev-utils/printHostingInstructions.js
@@ -26,11 +26,9 @@ function printHostingInstructions(
printBaseMessage(buildFolder, publicPathname);
printDeployInstructions(publicUrl, hasDeployScript, useYarn);
-
} else if (publicPath !== '/') {
// "homepage": "http://mywebsite.com/project"
printBaseMessage(buildFolder, publicPath);
-
} else {
// "homepage": "http://mywebsite.com"
// or no homepage
@@ -39,40 +37,36 @@ function printHostingInstructions(
printStaticServerInstructions(buildFolder, useYarn);
}
console.log();
+ console.log('Find out more about deployment here:');
+ console.log();
+ console.log(` ${chalk.yellow('http://bit.ly/2vY88Kr')}`);
+ console.log();
}
function printBaseMessage(buildFolder, hostingLocation) {
- console.log(
- `The project was built assuming it is hosted at ${chalk.green(
- hostingLocation || 'the server root'
- )}.`
- );
- console.log(
- `You can control this with the ${chalk.green(
- 'homepage'
- )} field in your ${chalk.cyan('package.json')}.`
- );
-
- if (!hostingLocation) {
- console.log('For example, add this to build it for GitHub Pages:');
- console.log();
-
- console.log(
- ` ${chalk.green('"homepage"')} ${chalk.cyan(':')} ${chalk.green(
- '"http://myname.github.io/myapp"'
- )}${chalk.cyan(',')}`
- );
- }
+ console.log(
+ `The project was built assuming it is hosted at ${chalk.green(
+ hostingLocation || 'the server root'
+ )}.`
+ );
+ console.log(
+ `You can control this with the ${chalk.green(
+ 'homepage'
+ )} field in your ${chalk.cyan('package.json')}.`
+ );
+
+ if (!hostingLocation) {
+ console.log('For example, add this to build it for GitHub Pages:');
console.log();
console.log(
- `The ${chalk.cyan(buildFolder)} folder is ready to be deployed.`
+ ` ${chalk.green('"homepage"')} ${chalk.cyan(':')} ${chalk.green(
+ '"http://myname.github.io/myapp"'
+ )}${chalk.cyan(',')}`
);
- console.log()
- console.log('Find out more about deployment here:');
- console.log();
- console.log(` ${chalk.yellow('http://bit.ly/2vY88Kr')}`);
- console.log();
+ }
+ console.log();
+ console.log(`The ${chalk.cyan(buildFolder)} folder is ready to be deployed.`);
}
function printDeployInstructions(publicUrl, hasDeployScript, useYarn) {
@@ -88,20 +82,24 @@ function printDeployInstructions(publicUrl, hasDeployScript, useYarn) {
}
console.log();
- console.log(`Add the following script in your ${chalk.cyan(
- 'package.json'
- )}.`);
+ console.log(
+ `Add the following script in your ${chalk.cyan('package.json')}.`
+ );
console.log();
console.log(` ${chalk.dim('// ...')}`);
console.log(` ${chalk.yellow('"scripts"')}: {`);
console.log(` ${chalk.dim('// ...')}`);
- console.log(` ${chalk.yellow('"predeploy"')}: ${chalk.yellow(
- '"npm run build",'
- )}`);
- console.log(` ${chalk.yellow('"deploy"')}: ${chalk.yellow(
- '"gh-pages -d build"'
- )}`);
+ console.log(
+ ` ${chalk.yellow('"predeploy"')}: ${chalk.yellow(
+ '"npm run build",'
+ )}`
+ );
+ console.log(
+ ` ${chalk.yellow('"deploy"')}: ${chalk.yellow(
+ '"gh-pages -d build"'
+ )}`
+ );
console.log(' }');
console.log();
--
GitLab