Skip to content
GitLab
Commit 915b1300 authored by Rory Hunter's avatar Rory Hunter Committed by Joe Haddad
Browse files

Make node version check more robust in e2e.sh (#1295)

parent c9bc6ce3
4 merge requests!12191Lim.Pisey.168:/Identified - We are currently investigating reports of missing build logs. The issue has been identified and a resolution is in progress. We will provide a further update when available.Mar 21, 09:02 UTC,!12853brikk,!5717Automatically extract project file structure from build bundle file,!1933Add note about installing watchman
Hide whitespace changes
Inline Side-by-side
Showing
with 1 addition and 1 deletion
+1 -1
tasks/e2e-simple.sh
+ 1
- 1
View file @ 915b1300
...@@ -68,7 +68,7 @@ root_path=$PWD ...@@ -68,7 +68,7 @@ root_path=$PWD
npm install npm install
# If the node version is < 4, the script should just give an error. # If the node version is < 4, the script should just give an error.
if [ `node --version | sed -e 's/^v//' -e 's/\..\+//g'` -lt 4 ] if [[ `node --version | sed -e 's/^v//' -e 's/\..*//g'` -lt 4 ]]
then then
cd $temp_app_path cd $temp_app_path
err_output=`node "$root_path"/packages/create-react-app/index.js test-node-version 2>&1 > /dev/null || echo ''` err_output=`node "$root_path"/packages/create-react-app/index.js test-node-version 2>&1 > /dev/null || echo ''`
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment