Commit 93029f83 authored by Joe Haddad's avatar Joe Haddad Committed by GitHub
Browse files

Remove superfluous lodash usage (#2938)

parent 10c1f577
Showing with 8 additions and 11 deletions
+8 -11
...@@ -9,12 +9,11 @@ ...@@ -9,12 +9,11 @@
'use strict'; 'use strict';
const get = require('lodash/get');
const chalk = require('chalk'); const chalk = require('chalk');
module.exports = function printBuildError(err) { module.exports = function printBuildError(err) {
const message = get(err, 'message'); const message = err != null && err.message;
const stack = get(err, 'stack'); const stack = err != null && err.stack;
// Add more helpful message for UglifyJs error // Add more helpful message for UglifyJs error
if ( if (
...@@ -23,24 +22,22 @@ module.exports = function printBuildError(err) { ...@@ -23,24 +22,22 @@ module.exports = function printBuildError(err) {
message.indexOf('from UglifyJs') !== -1 message.indexOf('from UglifyJs') !== -1
) { ) {
try { try {
const matched = /Unexpected token:(.+)\[(.+):(.+),(.+)\]\[.+\]/.exec( const matched = /(.+)\[(.+):(.+),(.+)\]\[.+\]/.exec(stack);
stack
);
if (!matched) { if (!matched) {
throw new Error( throw new Error('Using errors for control flow is bad.');
"The regex pattern is not matched. Maybe UglifyJs changed it's message?"
);
} }
const problemPath = matched[2]; const problemPath = matched[2];
const line = matched[3]; const line = matched[3];
const column = matched[4]; const column = matched[4];
console.log( console.log(
'Failed to minify the code from this file: \n\n', 'Failed to minify the code from this file: \n\n',
chalk.yellow(`${problemPath} line ${line}:${column}`), chalk.yellow(
`\t${problemPath}:${line}${column !== '0' ? ':' + column : ''}`
),
'\n' '\n'
); );
} catch (ignored) { } catch (ignored) {
console.log('Failed to minify the code.', err); console.log('Failed to minify the bundle.', err);
} }
console.log('Read more here: http://bit.ly/2tRViJ9'); console.log('Read more here: http://bit.ly/2tRViJ9');
} else { } else {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment