Remove 'guard-for-in' lint rule (#1773)

Iterating over an object's keys using `for/in` is idiomatic and it's safe (in all modern browsers) to not check hasOwnProperty as long as the object is a plain object. Can we remove this lint rule?

Remove 'guard-for-in' lint rule (#1773)
Iterating over an object's keys using `for/in` is idiomatic and it's safe (in all modern browsers) to not check hasOwnProperty as long as the object is a plain object. Can we remove this lint rule?
9c9f8f66 · Ben Alpert · Dan Abramov · 8c00af14 · 9c9f8f66
Commit 9c9f8f66 authored 8 years ago by Ben Alpert Committed by Dan Abramov 8 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 0 additions and 1 deletion
+0 -1
--- a/packages/eslint-config-react-app/index.js
+++ b/packages/eslint-config-react-app/index.js
@@ -59,7 +59,6 @@ module.exports = {
    'default-case': ['warn', { commentPattern: '^no default$' }],
    'dot-location': ['warn', 'property'],
    eqeqeq: ['warn', 'allow-null'],
-    'guard-for-in': 'warn',
    'new-parens': 'warn',
    'no-array-constructor': 'warn',
    'no-caller': 'warn',