Internal Webpack paths should not be clickable

9e733b57 · Dan Abramov · 172264ef · 9e733b57
Commit 9e733b57 authored 7 years ago by Dan Abramov
Hide whitespace changes
Inline Side-by-side

Showing

with 14 additions and 8 deletions
+14 -8
--- a/packages/react-error-overlay/src/components/frame.js
+++ b/packages/react-error-overlay/src/components/frame.js
@@ -267,14 +267,20 @@ function createFrame(
  let onSourceClick = null;
  if (sourceFileName) {
-    onSourceClick = () => {
+    // e.g. "/path-to-my-app/webpack/bootstrap eaddeb46b67d75e4dfc1"
-      fetch(
+    const isInternalWebpackBootstrapCode = sourceFileName
-        '/__open-stack-frame-in-editor?fileName=' +
+      .trim()
-          window.encodeURIComponent(sourceFileName) +
+      .indexOf(' ') !== -1;
-          '&lineNumber=' +
+    if (!isInternalWebpackBootstrapCode) {
-          window.encodeURIComponent(sourceLineNumber || 1)
+      onSourceClick = () => {
-      ).then(() => {}, () => {});
+        fetch(
-    };
+          '/__open-stack-frame-in-editor?fileName=' +
+            window.encodeURIComponent(sourceFileName) +
+            '&lineNumber=' +
+            window.encodeURIComponent(sourceLineNumber || 1)
+        ).then(() => {}, () => {});
+      };
+    }
  }
  const elem = frameDiv(