False expression should not be in dependencies

a85ae1d9 · Joe Haddad · ee3b788f · a85ae1d9
Unverified Commit a85ae1d9 authored 8 years ago by Joe Haddad
Hide whitespace changes
Inline Side-by-side

Showing

with 5 additions and 2 deletions
+5 -2
--- a/packages/create-react-app/index.js
+++ b/packages/create-react-app/index.js
@@ -164,8 +164,11 @@ function install(useYarn, dependencies, verbose, isOnline) {
      args = [
        'add',
        '--exact',
-        isOnline === false && '--offline'
+      ];
-      ].concat(dependencies);
+      if (!isOnline) {
+        args.push('--offline');
+      }
+      [].push.apply(args, dependencies);
      if (!isOnline) {
        console.log(chalk.yellow('You appear to be offline.'));