Commit b25c1339 authored by Dan Abramov's avatar Dan Abramov Committed by GitHub
Browse files

Skip React frames that are too close (#2143)

parent 76d2d848
Showing with 15 additions and 0 deletions
+15 -0
...@@ -13,11 +13,26 @@ function massage( ...@@ -13,11 +13,26 @@ function massage(
// Reassemble the stack with full filenames provided by React // Reassemble the stack with full filenames provided by React
let stack = ''; let stack = '';
let lastFilename;
let lastLineNumber;
for (let index = 0; index < frames.length; ++index) { for (let index = 0; index < frames.length; ++index) {
const { fileName, lineNumber } = frames[index]; const { fileName, lineNumber } = frames[index];
if (fileName == null || lineNumber == null) { if (fileName == null || lineNumber == null) {
continue; continue;
} }
// TODO: instead, collapse them in the UI
if (
fileName === lastFilename &&
typeof lineNumber === 'number' &&
typeof lastLineNumber === 'number' &&
Math.abs(lineNumber - lastLineNumber) < 3
) {
continue;
}
lastFilename = fileName;
lastLineNumber = lineNumber;
let { functionName } = frames[index]; let { functionName } = frames[index];
functionName = functionName || '(anonymous function)'; functionName = functionName || '(anonymous function)';
stack += `in ${functionName} (at ${fileName}:${lineNumber})\n`; stack += `in ${functionName} (at ${fileName}:${lineNumber})\n`;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment