From b98d5c9f33f08f42c346a58d505de510ebebea5e Mon Sep 17 00:00:00 2001 From: John Freeman <jfreeman08@gmail.com> Date: Fri, 21 Sep 2018 11:37:45 -0500 Subject: [PATCH] Move favicon.ico <link> to accommodate Chrome (#4891) Chrome requests `favicon.ico` on every route change, but stops if the `<link>` for it occurs early enough in the page. [Several](https://stackoverflow.com/questions/35409588/favicon-requested-on-every-route-change) other [people](https://github.com/ctrlplusb/react-universally/issues/145) have been running into this issue since at least February 2016. --- packages/react-scripts/template/public/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/public/index.html b/packages/react-scripts/template/public/index.html index ed0ebafa1..73b2ecd7f 100644 --- a/packages/react-scripts/template/public/index.html +++ b/packages/react-scripts/template/public/index.html @@ -2,6 +2,7 @@ <html lang="en"> <head> <meta charset="utf-8"> + <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico"> <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> <meta name="theme-color" content="#000000"> <!-- @@ -9,7 +10,6 @@ homescreen on Android. See https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/ --> <link rel="manifest" href="%PUBLIC_URL%/manifest.json"> - <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico"> <!-- Notice the use of %PUBLIC_URL% in the tags above. It will be replaced with the URL of the `public` folder during the build. -- GitLab