Move favicon.ico <link> to accommodate Chrome (#4891)

Chrome requests `favicon.ico` on every route change, but stops if the `<link>` for it occurs early enough in the page. [Several](https://stackoverflow.com/questions/35409588/favicon-requested-on-every-route-change) other [people](https://github.com/ctrlplusb/react-universally/issues/145) have been running into this issue since at least February 2016.

Move favicon.ico <link> to accommodate Chrome (#4891)
Chrome requests `favicon.ico` on every route change, but stops if the `<link>` for it occurs early enough in the page. [Several](https://stackoverflow.com/questions/35409588/favicon-requested-on-every-route-change) other [people](https://github.com/ctrlplusb/react-universally/issues/145) have been running into this issue since at least February 2016.
b98d5c9f · John Freeman · Joe Haddad · fdc916a5 · b98d5c9f
Commit b98d5c9f authored 6 years ago by John Freeman Committed by Joe Haddad 6 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 1 addition and 1 deletion
+1 -1
--- a/packages/react-scripts/template/public/index.html
+++ b/packages/react-scripts/template/public/index.html
@@ -2,6 +2,7 @@
 <html lang="en">
  <head>
    <meta charset="utf-8">
+    <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
    <meta name="theme-color" content="#000000">
    <!--
@@ -9,7 +10,6 @@
      homescreen on Android. See https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/
    -->
    <link rel="manifest" href="%PUBLIC_URL%/manifest.json">
-    <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico">
    <!--
      Notice the use of %PUBLIC_URL% in the tags above.
      It will be replaced with the URL of the `public` folder during the build.