Commit bc2fc808 authored by creynders's avatar creynders Committed by Dan Abramov
Browse files

eject: Additionally remove `react-scripts` from dependencies (#1458)

ATM if react-scripts is (erroneously) declared in `dependencies` instead of `devDependencies` or isn't declared at all, the `eject` script will fail half-way. This change makes it more robust, react-scripts will be removed from either, if present.
parent dd788b67
No related merge requests found
Showing with 8 additions and 2 deletions
+8 -2
......@@ -93,8 +93,14 @@ prompt(
console.log(cyan('Updating the dependencies'));
var ownPackageName = ownPackage.name;
console.log(' Removing ' + cyan(ownPackageName) + ' from devDependencies');
delete appPackage.devDependencies[ownPackageName];
if (appPackage.devDependencies[ownPackageName]) {
console.log(' Removing ' + cyan(ownPackageName) + ' from devDependencies');
delete appPackage.devDependencies[ownPackageName];
}
if (appPackage.dependencies[ownPackageName]) {
console.log(' Removing ' + cyan(ownPackageName) + ' from dependencies');
delete appPackage.dependencies[ownPackageName];
}
Object.keys(ownPackage.dependencies).forEach(function (key) {
// For some reason optionalDependencies end up in dependencies after install
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment