Commit bf5a4bf9 authored by Irvin Denzel Torcuato's avatar Irvin Denzel Torcuato Committed by Dan Abramov
Browse files

Feed correct line number to gvim on launch (#5202)

Clicking Error overlay should feed the correct line number for gvim.

Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running.

Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM

Relates to https://github.com/facebook/create-react-app/issues/2636.
parent b1033769
4 merge requests!12191Lim.Pisey.168:/Identified - We are currently investigating reports of missing build logs. The issue has been identified and a resolution is in progress. We will provide a further update when available.Mar 21, 09:02 UTC,!12853brikk,!5717Automatically extract project file structure from build bundle file,!5480<!-- Thank you for sending the PR!
Showing with 2 additions and 0 deletions
+2 -0
...@@ -67,6 +67,7 @@ const COMMON_EDITORS_LINUX = { ...@@ -67,6 +67,7 @@ const COMMON_EDITORS_LINUX = {
code: 'code', code: 'code',
'code-insiders': 'code-insiders', 'code-insiders': 'code-insiders',
emacs: 'emacs', emacs: 'emacs',
gvim: 'gvim',
'idea.sh': 'idea', 'idea.sh': 'idea',
'phpstorm.sh': 'phpstorm', 'phpstorm.sh': 'phpstorm',
'pycharm.sh': 'pycharm', 'pycharm.sh': 'pycharm',
...@@ -136,6 +137,7 @@ function getArgumentsForLineNumber( ...@@ -136,6 +137,7 @@ function getArgumentsForLineNumber(
case 'vim': case 'vim':
case 'mvim': case 'mvim':
case 'joe': case 'joe':
case 'gvim':
return ['+' + lineNumber, fileName]; return ['+' + lineNumber, fileName];
case 'emacs': case 'emacs':
case 'emacsclient': case 'emacsclient':
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment