From bf5a4bf9897dec5bbc5ff1cbde87df8bc7487da9 Mon Sep 17 00:00:00 2001
From: Irvin Denzel Torcuato <identor@users.noreply.github.com>
Date: Tue, 2 Oct 2018 05:08:53 +0800
Subject: [PATCH] Feed correct line number to gvim on launch (#5202)
Clicking Error overlay should feed the correct line number for gvim.
Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running.
Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM
Relates to https://github.com/facebook/create-react-app/issues/2636.
---
packages/react-dev-utils/launchEditor.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/packages/react-dev-utils/launchEditor.js b/packages/react-dev-utils/launchEditor.js
index 65acefbe0..705fac51e 100644
--- a/packages/react-dev-utils/launchEditor.js
+++ b/packages/react-dev-utils/launchEditor.js
@@ -67,6 +67,7 @@ const COMMON_EDITORS_LINUX = {
code: 'code',
'code-insiders': 'code-insiders',
emacs: 'emacs',
+ gvim: 'gvim',
'idea.sh': 'idea',
'phpstorm.sh': 'phpstorm',
'pycharm.sh': 'pycharm',
@@ -136,6 +137,7 @@ function getArgumentsForLineNumber(
case 'vim':
case 'mvim':
case 'joe':
+ case 'gvim':
return ['+' + lineNumber, fileName];
case 'emacs':
case 'emacsclient':
--
GitLab