From d61a3313f6eeb10cafee9574dddba1971a84cba5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juhamatti=20Niemel=C3=A4?= <iiska@iki.fi>
Date: Tue, 9 Jan 2018 17:13:59 +0200
Subject: [PATCH] Fix asset size comparison for multi build stats (#3514)
If create-react-app project is ejected and webpack configuration is
modified to multi build setup FileSizeReporter would fail.
In those situations `webpackStats` parameter would contain stats array
for each build. This fix will try to access stats and then falls back
to using plaing webpackStats object.
---
packages/react-dev-utils/FileSizeReporter.js | 38 ++++++++++++--------
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/packages/react-dev-utils/FileSizeReporter.js b/packages/react-dev-utils/FileSizeReporter.js
index 01ce52c6b..68aae411f 100644
--- a/packages/react-dev-utils/FileSizeReporter.js
+++ b/packages/react-dev-utils/FileSizeReporter.js
@@ -25,21 +25,29 @@ function printFileSizesAfterBuild(
) {
var root = previousSizeMap.root;
var sizes = previousSizeMap.sizes;
- var assets = webpackStats
- .toJson()
- .assets.filter(asset => /\.(js|css)$/.test(asset.name))
- .map(asset => {
- var fileContents = fs.readFileSync(path.join(root, asset.name));
- var size = gzipSize(fileContents);
- var previousSize = sizes[removeFileNameHash(root, asset.name)];
- var difference = getDifferenceLabel(size, previousSize);
- return {
- folder: path.join(path.basename(buildFolder), path.dirname(asset.name)),
- name: path.basename(asset.name),
- size: size,
- sizeLabel: filesize(size) + (difference ? ' (' + difference + ')' : ''),
- };
- });
+ var assets = (webpackStats.stats || [webpackStats])
+ .map(stats =>
+ stats
+ .toJson()
+ .assets.filter(asset => /\.(js|css)$/.test(asset.name))
+ .map(asset => {
+ var fileContents = fs.readFileSync(path.join(root, asset.name));
+ var size = gzipSize(fileContents);
+ var previousSize = sizes[removeFileNameHash(root, asset.name)];
+ var difference = getDifferenceLabel(size, previousSize);
+ return {
+ folder: path.join(
+ path.basename(buildFolder),
+ path.dirname(asset.name)
+ ),
+ name: path.basename(asset.name),
+ size: size,
+ sizeLabel:
+ filesize(size) + (difference ? ' (' + difference + ')' : '')
+ };
+ })
+ )
+ .reduce((single, all) => all.concat(single), []);
assets.sort((a, b) => b.size - a.size);
var longestSizeLabelLength = Math.max.apply(
null,
--
GitLab