Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Meta
create-react-app
Commits
e7c113eb
Commit
e7c113eb
authored
7 years ago
by
Kant
Committed by
Dan Abramov
7 years ago
Browse files
Options
Download
Email Patches
Plain Diff
Webpack config typo (#2193)
* Webpack config typo * Webpack config more typo
parent
a61be9c6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
packages/react-scripts/config/webpack.config.dev.js
+3
-3
packages/react-scripts/config/webpack.config.dev.js
packages/react-scripts/config/webpack.config.prod.js
+3
-3
packages/react-scripts/config/webpack.config.prod.js
with
6 additions
and
6 deletions
+6
-6
packages/react-scripts/config/webpack.config.dev.js
+
3
-
3
View file @
e7c113eb
...
@@ -146,10 +146,10 @@ module.exports = {
...
@@ -146,10 +146,10 @@ module.exports = {
include
:
paths
.
appSrc
,
include
:
paths
.
appSrc
,
},
},
// ** ADDING/UPDATING LOADERS **
// ** ADDING/UPDATING LOADERS **
// The "
url
" loader handles all assets unless explicitly excluded.
// The "
file
" loader handles all assets unless explicitly excluded.
// The `exclude` list *must* be updated with every change to loader extensions.
// The `exclude` list *must* be updated with every change to loader extensions.
// When adding a new loader, you must add its `test`
// When adding a new loader, you must add its `test`
// as a new entry in the `exclude` list for "
url
" loader.
// as a new entry in the `exclude` list for "
file
" loader.
// "file" loader makes sure those assets get served by WebpackDevServer.
// "file" loader makes sure those assets get served by WebpackDevServer.
// When you `import` an asset, you get its (virtual) filename.
// When you `import` an asset, you get its (virtual) filename.
...
@@ -233,7 +233,7 @@ module.exports = {
...
@@ -233,7 +233,7 @@ module.exports = {
],
],
},
},
// ** STOP ** Are you adding a new loader?
// ** STOP ** Are you adding a new loader?
// Remember to add the new extension(s) to the "
url
" loader exclusion list.
// Remember to add the new extension(s) to the "
file
" loader exclusion list.
],
],
},
},
plugins
:
[
plugins
:
[
...
...
This diff is collapsed.
Click to expand it.
packages/react-scripts/config/webpack.config.prod.js
+
3
-
3
View file @
e7c113eb
...
@@ -145,10 +145,10 @@ module.exports = {
...
@@ -145,10 +145,10 @@ module.exports = {
include
:
paths
.
appSrc
,
include
:
paths
.
appSrc
,
},
},
// ** ADDING/UPDATING LOADERS **
// ** ADDING/UPDATING LOADERS **
// The "
url
" loader handles all assets unless explicitly excluded.
// The "
file
" loader handles all assets unless explicitly excluded.
// The `exclude` list *must* be updated with every change to loader extensions.
// The `exclude` list *must* be updated with every change to loader extensions.
// When adding a new loader, you must add its `test`
// When adding a new loader, you must add its `test`
// as a new entry in the `exclude` list in the "
url
" loader.
// as a new entry in the `exclude` list in the "
file
" loader.
// "file" loader makes sure those assets end up in the `build` folder.
// "file" loader makes sure those assets end up in the `build` folder.
// When you `import` an asset, you get its filename.
// When you `import` an asset, you get its filename.
...
@@ -243,7 +243,7 @@ module.exports = {
...
@@ -243,7 +243,7 @@ module.exports = {
// Note: this won't work without `new ExtractTextPlugin()` in `plugins`.
// Note: this won't work without `new ExtractTextPlugin()` in `plugins`.
},
},
// ** STOP ** Are you adding a new loader?
// ** STOP ** Are you adding a new loader?
// Remember to add the new extension(s) to the "
url
" loader exclusion list.
// Remember to add the new extension(s) to the "
file
" loader exclusion list.
],
],
},
},
plugins
:
[
plugins
:
[
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment