Move favicon outside src

README.md

@@ -48,12 +48,12 @@ Inside that directory, it will generate the initial project structure and instal
 my-app/
   README.md
   index.html
+  favicon.ico
   node_modules/
   package.json
   src/
     App.css
     App.js
-    favicon.ico
     index.css
     index.js
     logo.svg

config/webpack.config.dev.js

@@ -23,6 +23,7 @@ if (process.argv[2] === '--debug-template') {
 var srcPath = path.resolve(__dirname, relativePath, 'src');
 var nodeModulesPath = path.join(__dirname, '..', 'node_modules');
 var indexHtmlPath = path.resolve(__dirname, relativePath, 'index.html');
+var faviconPath = path.resolve(__dirname, relativePath, 'favicon.ico');
 var buildPath = path.join(__dirname, isInNodeModules ? '../../..' : '..', 'build');
 
 module.exports = {
@@ -91,7 +92,7 @@ module.exports = {
     new HtmlWebpackPlugin({
       inject: true,
       template: indexHtmlPath,
-      favicon: path.join(srcPath, 'favicon.ico'),
+      favicon: faviconPath,
     }),
     new webpack.DefinePlugin({ 'process.env.NODE_ENV': '"development"' }),
     // Note: only CSS is currently hot reloaded

config/webpack.config.prod.js

@@ -24,6 +24,7 @@ if (process.argv[2] === '--debug-template') {
 var srcPath = path.resolve(__dirname, relativePath, 'src');
 var nodeModulesPath = path.join(__dirname, '..', 'node_modules');
 var indexHtmlPath = path.resolve(__dirname, relativePath, 'index.html');
+var faviconPath = path.resolve(__dirname, relativePath, 'favicon.ico');
 var buildPath = path.join(__dirname, isInNodeModules ? '../../..' : '..', 'build');
 
 module.exports = {
@@ -92,7 +93,7 @@ module.exports = {
     new HtmlWebpackPlugin({
       inject: true,
       template: indexHtmlPath,
-      favicon: path.join(srcPath, 'favicon.ico'),
+      favicon: faviconPath,
       minify: {
         removeComments: true,
         collapseWhitespace: true,