Ensure proxy url starts with `http://` or `https://` (#1890)

f61cba10 · Buns Shar · Joe Haddad · cb41a76e · f61cba10
Commit f61cba10 authored 8 years ago by Buns Shar Committed by Joe Haddad 8 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 8 additions and 0 deletions
+8 -0
--- a/packages/react-scripts/scripts/utils/addWebpackMiddleware.js
+++ b/packages/react-scripts/scripts/utils/addWebpackMiddleware.js
@@ -89,6 +89,14 @@ module.exports = function addWebpackMiddleware(devServer) {
        )
      );
      process.exit(1);
+      // Test that proxy url specified starts with http:// or https://
+    } else if (!/^http(s)?:\/\//.test(proxy)) {
+      console.log(
+        chalk.red(
+          'When "proxy" is specified in package.json it must start with either http:// or https://'
+        )
+      );
+      process.exit(1);
    }

    // Otherwise, if proxy is specified, we will let it handle any request.