1. 30 Jun, 2018 1 commit
  2. 25 Jun, 2018 1 commit
  3. 23 Jun, 2018 1 commit
  4. 20 Jun, 2018 1 commit
  5. 18 Jun, 2018 2 commits
  6. 07 Jun, 2018 1 commit
  7. 05 Jun, 2018 3 commits
  8. 04 Jun, 2018 1 commit
  9. 03 Jun, 2018 1 commit
  10. 01 Jun, 2018 1 commit
  11. 31 May, 2018 3 commits
  12. 24 May, 2018 2 commits
  13. 23 May, 2018 1 commit
    • Graeme's avatar
      Update paths.js, rename shadow path variable (#4435) · 61c864c3
      Graeme authored
      * Update paths.js, rename shadow path variable
      
      This file requires the "path" module and sets it to a variable `path`. The function `ensureSlash` also has a variable `path` that then shadows the `path` module.
      
      * Update paths.js
      61c864c3
  14. 22 May, 2018 1 commit
  15. 20 May, 2018 5 commits
    • Luis Nell's avatar
      Update node-sass-chokidar docs (#4205) · 0dfc6f6e
      Luis Nell authored
      * Removes Chokidar Recursive Flag
      
      According to the changelog it is not necessary anymore as it doesn't do anything.
      
      * Removes initial build on SCSS watch
      
      Chokidar now does this on it's own.
      
      * Removes sass watch recursive, default include-path
      
      as proposed by @michaelwayman
      
      * Removes another left-over build-css
      0dfc6f6e
    • jamesvsshark's avatar
      e645d3e8
    • Craig Mulligan's avatar
      `.mjs` should not resolve before .js files (#4085) (#4318) · 0e0f260e
      Craig Mulligan authored
      Support for .mjs files added in #3239 did not account for npm libraries which ship native mjs files alongside js files. This accounts for this by ensuring .js files resolve before their accompanying .mjs file. Note that this is not an ideal end state since selecting a .mjs over a .js extension should be the result of whether `import` was used instead of `require()` in a node environment with native ESM support (currently via `--experimental-modules`). Instead, this change just *always* selects a .js extension before the .mjs extension if it exists.
      
      This unbreaks support for using GraphQL (relay, apollo, etc) within create-react-app projects.
      0e0f260e
    • Jack Zhao's avatar
      Webpack4 (#4490) · d1454feb
      Jack Zhao authored
      * - [x] Upgrade to webpack 4.8.X
      - [x] Utilize webpack 4 development and production modes
      - [x] Upgrade webpack dev server
      - [x] Webpack 4 compatible release of thread-loader
      - [x] Webpack 4 compatible release of HtmlWebpackPlugin
      - [x] Webpack 4 compatible release of SwPrecacheWebpackPlugin
      - [x] Webpack 4 compatible release of WebpackManifestPlugin
      - [x] Update README
      - [x] Update WebpackDevServerUtils
      - [x] Update InterpolateHtmlPlugin
      - [x] Update ModuleScopePlugin
      - [x] Update WatchMissingNodeModulesPlugin
      - [x] Move UglifyJS options to webpack 4 optimize
      - [x] Move InterpolateHtmlPlugin to make it tapable on HtmlWebpackPlugin
      - [x] vendor splitting via splitChunks.splitChunks (https://twitter.com/wSokra/status/969633336732905474)
      - [x] long term caching via splitChunks.runtimeChunk (https://twitter.com/wSokra/status/969679223278505985)
      - [x] Make sure process.env.NODE_ENV is proxied correctly to `react-error-overlay`
      - [x] Implicit webpack.NamedModulesPlugin in dev config as its default in webpack 4
      - [x] Disable webpack performance hints as we have our own filesize reporter
      - [x] Replace ExtractTextPlugin with MiniCssExtractPlugin
      - [x] Switch to css whole file minification via OptimizeCSSAssetsPlugin rather than per module css minification to gain performance
      
      * disable module concatenation
      
      * fix cleanup
      
      * fix optimization
      
      * restore tmp removal
      
      * preserve
      
      * fix css tests
      
      * fix test run
      
      * fix svg test
      
      * revert tmp dir
      
      * fix import
      
      * fix import
      
      * help debugging
      
      * fix tests
      
      * fix sass test
      
      * restore cleanup
      d1454feb
    • Andreas Cederström's avatar
      - [x] Upgrade to webpack 4.8.X (#4077) · d72678fb
      Andreas Cederström authored
      - [x] Utilize webpack 4 development and production modes
      - [x] Upgrade webpack dev server
      - [x] Webpack 4 compatible release of thread-loader
      - [x] Webpack 4 compatible release of HtmlWebpackPlugin
      - [x] Webpack 4 compatible release of SwPrecacheWebpackPlugin
      - [x] Webpack 4 compatible release of WebpackManifestPlugin
      - [x] Update README
      - [x] Update WebpackDevServerUtils
      - [x] Update InterpolateHtmlPlugin
      - [x] Update ModuleScopePlugin
      - [x] Update WatchMissingNodeModulesPlugin
      - [x] Move UglifyJS options to webpack 4 optimize
      - [x] Move InterpolateHtmlPlugin to make it tapable on HtmlWebpackPlugin
      - [x] vendor splitting via splitChunks.splitChunks (https://twitter.com/wSokra/status/969633336732905474)
      - [x] long term caching via splitChunks.runtimeChunk (https://twitter.com/wSokra/status/969679223278505985)
      - [x] Make sure process.env.NODE_ENV is proxied correctly to `react-error-overlay`
      - [x] Implicit webpack.NamedModulesPlugin in dev config as its default in webpack 4
      - [x] Disable webpack performance hints as we have our own filesize reporter
      - [x] Replace ExtractTextPlugin with MiniCssExtractPlugin
      - [x] Switch to css whole file minification via OptimizeCSSAssetsPlugin rather than per module css minification to gain performance
      d72678fb
  16. 16 May, 2018 1 commit
  17. 14 May, 2018 2 commits
  18. 12 May, 2018 1 commit
  19. 11 May, 2018 1 commit
  20. 09 May, 2018 1 commit
  21. 08 May, 2018 2 commits
    • William Chargin's avatar
      ensureSlash: Fix accidental string-to-NaN coercion (#4424) · 3aaddefc
      William Chargin authored
      Summary:
      The `hasSlash` method uses `path.substr(path, path.length - 1)` to
      remove the last character from `path`. Clearly, the first parameter is
      suspect; it should be `0`. The code works as written, but only very
      accidentally: the first parameter is coerced by `ToNumber` to `NaN`,
      which is then coerced by `ToInteger` to `+0`, per [the spec][1].
      
      [1]: https://www.ecma-international.org/ecma-262/6.0/#sec-string.prototype.substr
      
      Test Plan:
      Reading the spec should be sufficient. To verify in the Real World:
      ```js
      const path = "has-slash-but-does-not-need-slash/"
      const a = path.substr(path, path.length - 1);
      const b = path.substr(0, path.length - 1);
      console.log(a === b);  // true
      console.log(a);        // has-slash-but-does-not-need-slash
      ```
      
      wchargin-branch: ensureslash-accidental-coercion
      3aaddefc
    • arianon's avatar
      Update getCSSModuleLocalIdent to support Sass (#4391) · e5e9f59a
      arianon authored
      * Update getCSSModuleLocalIdent to support Sass
      
      * Fix Sass/SCSS index module tests
      
      Also make them more consistent with the non-index variants.
      e5e9f59a
  22. 30 Apr, 2018 1 commit
  23. 28 Apr, 2018 1 commit
  24. 27 Apr, 2018 5 commits