theme-color meta tag is inconsistent with manifest's theme-color
Created by: fang0rnz
Is this a bug report?
Yes
Did you try recovering your dependencies?
Yep
Which terms did you search for in User Guide?
(Write your answer here if relevant.)
Environment
-
node -v
: 9.11.1 -
npm -v
: 5.6.0 -
yarn --version
(if you use Yarn): 1.5.1 -
npm ls react-scripts
(if you haven’t ejected): 1.1.4
Then, specify:
- Operating system: Windows 10 x64
- Browser and version (if relevant): not relevant
Steps to Reproduce
- npx create-react-app my-app
- cd my-app
- Change theme-color on manifest.json to anything but the default
- yarn build
- check that built html has a meta tag specifying theme-color, it overrides what is specified on package.json:
Expected Behavior
built html should'nt have the default #000000 meta tag or it should match what you edited on manifest.json
Actual Behavior
Colors don't match. Mobile chrome's screen is still black and the added PWA also.
https://developers.google.com/web/updates/2015/08/using-manifest-to-set-sitewide-theme-color "If you page already has a theme-color meta tag — for example — then the page level configuration will be used instead of the value in the manifest."
Reproducible Demo
It's not necessary, just create a new app and you will see this happening.