react-error-overlay not open up file in windows (vscode)

Created by: sercangurbuz

Is this a bug report?

I hope so

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

WINDOWS_FILE_NAME_WHITELIST ,windows,react-error-overlay

Environment

Windows10,vscode

Steps to Reproduce

1. give runtime error in any component
2. try to locate the file clicking the error on overlay expecting vscode to open up the relevant file

Expected Behavior

I expect vscode to bring up the file which error is thrown in.

Actual Behavior

Absolute file path sent from webpackdevClient is considered as insecure and stuck in regex check WINDOWS_FILE_NAME_WHITELIST in react-error-overlay project.

Reproducible Demo

Say that ,File path is like below D:/Samples/new/src/App.js

is not valid according to regex /^[\p{L}0-9/.-_\]+$/u @acdlite

but if you remove the partition specifier from path like below it works and open up the file

/Samples/new/src/App.js

or

^[a-zA-Z]:/[\p{L}0-9/.-_\]+$

this regex helps accepting the partition specifier

Created by: gaearon

Send a PR please?

Created by: kanitsharma

@gaearon Is this up for grabs?

Created by: gaearon

Fixed by !5431 (merged).