react-error-overlay line numbers are wrong since 2.1.5 release
Created by: russelldavis
To reproduce: throw an error in your react app that results in the error overlay appearing. The line number it shows will be wrong (and thus, also the lines of code that it displays).
This was broken by the switch to eval-source-map in the 2.1.5 release. I confirmed that switching back to cheap-module-source-map
fixes the issue.
cc @Timer @jasonLaster @ianschmitz
Environment
Environment Info:
System: OS: macOS 10.14.3 CPU: x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz Binaries: Node: 11.6.0 - /usr/local/bin/node Yarn: 1.12.3 - /usr/local/bin/yarn npm: 6.5.0 - /usr/local/bin/npm Browsers: Chrome: 72.0.3626.109 Firefox: 65.0 Safari: 12.0.3 npmPackages: react: ^16.8.1 => 16.8.1 react-dom: ^16.8.1 => 16.8.1 react-scripts: ^2.1.4 => 2.1.5 npmGlobalPackages: create-react-app: Not Found