Skip to content
GitLab

Unlock deps

Closed Administrator requested to merge github/fork/cesine/unlock_deps into main

Created by: cesine

We found react-dev-utils was introducing multiple versions of other libs we consume such as @babel/code-frame due to the locked deps.

Excerpt from our yarn.lock:

react-dev-utils@^11.0.0:
  version "11.0.1"
  resolved "http://artifactory.shuttercorp.net/artifactory/api/npm/npm-composite/react-dev-utils/-/react-dev-utils-11.0.1.tgz#30106c2055acfd6b047d2dc478a85c356e66fe45"
  integrity sha1-MBBsIFWs/WsEfS3EeKhcNW5m/kU=
  dependencies:
    "@babel/code-frame" "7.10.4"
    address "1.1.2"
    browserslist "4.14.2"
    chalk "2.4.2"
    cross-spawn "7.0.3"
    detect-port-alt "1.1.6"
    escape-string-regexp "2.0.0"
    filesize "6.1.0"
    find-up "4.1.0"
    fork-ts-checker-webpack-plugin "4.1.6"
    global-modules "2.0.0"
    globby "11.0.1"
    gzip-size "5.1.1"
    immer "7.0.9"
    is-root "2.1.0"
    loader-utils "2.0.0"
    open "^7.0.2"
    pkg-up "3.1.0"
    prompts "2.4.0"
    react-error-overlay "^6.0.8"
    recursive-readdir "2.2.2"
    shell-quote "1.7.2"
    strip-ansi "6.0.0"
    text-table "0.2.0"

I looked for why this might be the case, it seems unintentional. normally I would also check in the yarn.lock when using unlocked deps, but https://github.com/facebook/create-react-app/issues/7765#issuecomment-538694289 asks that it be gitignored

ensure that our CI installs the latest versions of packages to discover potential issues our users may encounter.

  • [ ] run this PR in CI to find out if it does fail with latest deps Other PRs are failing too, so CI cant be used to measure this PR
Screen Shot 2020-11-23 at 10 41 19 PM

And locally


$ ./tasks/e2e-simple.sh
~/create-react-app/packages/react-error-overlay/src/__tests__/extract-source-map.js
  28:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

~/create-react-app/packages/react-error-overlay/src/__tests__/get-source-map.js
  58:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  59:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

~/create-react-app/packages/react-error-overlay/src/__tests__/parser/generic.js
  15:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  16:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  25:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  26:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

✖ 7 problems (7 errors, 0 warnings)