Update env.js without requirement for NODE_ENV, fix #10195

Created by: caub

Avoid throwing if NODE_ENV is not passed, to allow running eslint locally (as an IDE extension), with a local .eslintrc config using react-scripts webpack config for eslint-plugin-import webpack resolver fix #10195

requested review from @root

requested review from @root

requested review from @root

requested review from @root

added CLA Signed label

mentioned in issue #10195

Created by: SMAKSS

Review: Commented

Hi there, can you fill out the PR template to tell us what did you changed exactly and why it needs to be changed?

Created by: caub

Hey @SMAKSS, where can I find that template?

I've already added details in the related issues though: #10195

Created by: SMAKSS

Hey @SMAKSS, where can I find that template?

I've already added details in the related issues though: #10195

Well, it's not that fancy with so many requirements but you can find it here, you just need to describe what did you do, but for this particular case I guess mentioning the issue in the description (instead of the title) would be ok.

BTW, the CI pipelines are failing here and you need to check them and fix the problems to make your PR acceptable and make it ready for the review.

Created by: caub

@SMAKSS Thanks, updated description

I've ran npm run build and npm test at the root of CRA project, the tests pass.

The failures reported in the CI doesn't seem to relate to my changes (seems like eslint errors on different files)

Created by: caub

see https://dev.azure.com/facebook/create-react-app/_build/results?buildId=2203&view=logs&j=0df9ae8a-07e5-564e-7bab-60ae72ed0707&t=c701e052-963c-596e-1738-882004ae6f53

It seems failing due to lint errors in create-react-app/packages/react-error-overlay/src/tests/parser/generic.js, so it's unrelated to my change

Created by: stale[bot]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

added stale label

restored source branch github/fork/caub/patch-1