Skip to content
GitLab

Makes end-to-end testing crash on unhandled rejections

Merged Administrator requested to merge github/fork/dbismut/e2e-testing-to-crash-on-unhandled-rejection into master

Created by: dbismut

This makes sure that end-to-end-testing crash when scripts/*.js run into an unhandled promise rejection as explained here https://github.com/facebookincubator/create-react-app/issues/1806#issuecomment-286146425.

This code has been added at the beginning of each script:

process.on('unhandledRejection', err => {
  throw err;
});

Before

Faulty eject.js fails silently.

before before 2

After

Faulty eject.js makes end-to-end testing crash.

after

Note that the bug outlined above should be fixed by #1810.