Closed
requested to merge github/fork/einarlove/peer-dependencies-to-dependencies-in-eslint-config into master
Created by: einarlove
PeerDependencies is not deprecated, but they are a pain in the but.
$ yarn add eslint-config-react-app
yarn add v0.20.3
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "babel-eslint@^7.0.0".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint@^3.16.1".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint-plugin-flowtype@^2.21.0".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint-plugin-import@^2.0.1".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint-plugin-jsx-a11y@^2.0.0 || ^3.0.0 || ^4.0.0".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint-plugin-react@^6.4.1".
success Saved 1 new dependency.
└─ eslint-config-react-app@0.6.2
Since eslint-config-react-app depends on all the above packages, it should be installed alongside the package. This will mirror the same behaviour babel-preset-react-app has which is a breeze.
Should eslint also be installed automatically? I'm not sure. I'm leaving it as a peerDependency for now and would like to hear your thoughts.